-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove conventional commit check for PR #950
Conversation
Seems reasonable - how about also modifying the PR check a bit to help guide PR messages? Something like.
Perhaps this response should be on every PR? |
I think this specifically is a good message to put on PRs with non conventional commits titles. The whole paragraph would make more sense to me in I think a comment with this on every PR is too much, but I'd be keen on putting it for every first-contributor PR. EDIT: Also this is the matter of another PR imo |
yep I want another maintainer's opinion on this change before merging it btw. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check with another maintainer before merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sad to see this go but sounds reasonable 👍🏼
This removes conventional commit check for PRs. Since we use the PR title and description this is useless. IMPORTANT NOTE: This does **not** mean Ratatui abandons conventional commits. This only relates to commits in PRs.
13ffe9c
to
f6ebea1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #950 /- ##
=====================================
Coverage 91.9% 91.9%
=====================================
Files 61 61
Lines 15703 15723 20
=====================================
Hits 14436 14456 20
Misses 1267 1267 ☔ View full report in Codecov by Sentry. |
Every commit on main is made through a PR, internal PR commits don't matter. What would be great though is to check if the PR title matches the conventional commit style. |
yeah, I think we already do that in |
That's right I forgot about that, it's all good then. |
This removes conventional commit check for PRs.
Since we use the PR title and description this is useless. It fails a lot of time and we ignore it.
IMPORTANT NOTE: This does not mean Ratatui abandons conventional commits. This only relates to commits in PRs.