Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(canvas)!: add fill property to Rectangle #919

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(canvas)!: add fill property to Rectangle #919

wants to merge 2 commits into from

Conversation

SOF3
Copy link
Contributor

@SOF3 SOF3 commented Feb 4, 2024 •
edited
Loading

BREAKING CHANGE: Rectangle now has a fill field. Set as false for
original behavior.

Includes changes from #917 to reuse the step_points util

@SOF3
fix(canvas): compute circle coordinates with Pyth thm
26f05ec 
The original algorithm may cause holes when the circle is large
@SOF3
feat(canvas)!: add fill property to Rectangle
2157b5c 
BREAKING CHANGE: `Rectangle` now has a `fill` field. Set as `false` for
original behavior.
@github-actions github-actions bot added the Type: Breaking Change This change will cause application code to break and must be noted in the breaking changes docs etc. label Feb 4, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.1%. Comparing base (61a8278) to head (2157b5c).
Report is 298 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##            main    #919      /-   ##
=======================================
  Coverage   92.0%   92.1%    0.1%     
=======================================
  Files         61      61             
  Lines      15493   15702     209     
=======================================
  Hits       14259   14468     209     
  Misses      1234    1234

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SOF3 SOF3 mentioned this pull request Feb 4, 2024
Open
@SOF3 SOF3 mentioned this pull request Apr 8, 2024
Open
@joshka joshka requested a review from EdJoPaTo as a code owner June 3, 2024 01:32
@joshka joshka added the Status: Review Needed PR needs a review / Issue needs buy-in from other maintainers / users label Sep 27, 2024
@joshka joshka added this to the v0.29.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun Awaiting requested review from orhun

@mindoodoo mindoodoo Awaiting requested review from mindoodoo

@sayanarijit sayanarijit Awaiting requested review from sayanarijit

@joshka joshka Awaiting requested review from joshka

@kdheepak kdheepak Awaiting requested review from kdheepak

@Valentin271 Valentin271 Awaiting requested review from Valentin271

@EdJoPaTo EdJoPaTo Awaiting requested review from EdJoPaTo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Status: Review Needed PR needs a review / Issue needs buy-in from other maintainers / users Type: Breaking Change This change will cause application code to break and must be noted in the breaking changes docs etc.
Projects
None yet
Milestone
v0.29.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SOF3 @joshka