Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(table): correct column width behavior when widths are not provided #1409

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

docs(table): correct column width behavior when widths are not provided #1409

wants to merge 2 commits into from

Conversation

airblast-dev
Copy link
Contributor

The behavior when column widths were not provided is inconsistent in the Table docs.

The docs have been changed to reflect the current behavior where the available space is distributed equally between the columns if widths were not provided.

@airblast-dev airblast-dev requested a review from a team as a code owner October 7, 2024 20:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

🐰 Bencher Report

Branch1409/merge
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
barchart/render/2048📈 view plot
⚠️ NO THRESHOLD		193,950.00
barchart/render/256📈 view plot
⚠️ NO THRESHOLD		125,540.00
barchart/render/64📈 view plot
⚠️ NO THRESHOLD		82,079.00
barchart/render_grouped/2048📈 view plot
⚠️ NO THRESHOLD		338,970.00
barchart/render_grouped/256📈 view plot
⚠️ NO THRESHOLD		137,350.00
barchart/render_grouped/64📈 view plot
⚠️ NO THRESHOLD		125,060.00
barchart/render_horizontal/2048📈 view plot
⚠️ NO THRESHOLD		164,340.00
barchart/render_horizontal/256📈 view plot
⚠️ NO THRESHOLD		86,903.00
barchart/render_horizontal/64📈 view plot
⚠️ NO THRESHOLD		77,638.00
block/render_all_feature/100x50📈 view plot
⚠️ NO THRESHOLD		10,600.00
block/render_all_feature/200x50📈 view plot
⚠️ NO THRESHOLD		18,221.00
block/render_all_feature/256x256📈 view plot
⚠️ NO THRESHOLD		85,620.00
block/render_empty/100x50📈 view plot
⚠️ NO THRESHOLD		5,711.80
block/render_empty/200x50📈 view plot
⚠️ NO THRESHOLD		11,022.00
block/render_empty/256x256📈 view plot
⚠️ NO THRESHOLD		72,479.00
buffer/empty/16📈 view plot
⚠️ NO THRESHOLD		818.25
buffer/empty/255📈 view plot
⚠️ NO THRESHOLD		223,450.00
buffer/empty/64📈 view plot
⚠️ NO THRESHOLD		13,791.00
buffer/filled/16📈 view plot
⚠️ NO THRESHOLD		826.60
buffer/filled/255📈 view plot
⚠️ NO THRESHOLD		226,130.00
buffer/filled/64📈 view plot
⚠️ NO THRESHOLD		14,158.00
buffer/with_lines/16📈 view plot
⚠️ NO THRESHOLD		14,123.00
buffer/with_lines/255📈 view plot
⚠️ NO THRESHOLD		17,561.00
buffer/with_lines/64📈 view plot
⚠️ NO THRESHOLD		16,885.00
line_render/Center/0📈 view plot
⚠️ NO THRESHOLD		4.04
line_render/Center/10📈 view plot
⚠️ NO THRESHOLD		634.86
line_render/Center/3📈 view plot
⚠️ NO THRESHOLD		302.81
line_render/Center/4📈 view plot
⚠️ NO THRESHOLD		345.24
line_render/Center/42📈 view plot
⚠️ NO THRESHOLD		839.19
line_render/Center/6📈 view plot
⚠️ NO THRESHOLD		399.10
line_render/Center/7📈 view plot
⚠️ NO THRESHOLD		453.25
line_render/Left/0📈 view plot
⚠️ NO THRESHOLD		4.05
line_render/Left/10📈 view plot
⚠️ NO THRESHOLD		592.46
line_render/Left/3📈 view plot
⚠️ NO THRESHOLD		225.77
line_render/Left/4📈 view plot
⚠️ NO THRESHOLD		237.81
line_render/Left/42📈 view plot
⚠️ NO THRESHOLD		835.41
line_render/Left/6📈 view plot
⚠️ NO THRESHOLD		381.09
line_render/Left/7📈 view plot
⚠️ NO THRESHOLD		401.85
line_render/Right/0📈 view plot
⚠️ NO THRESHOLD		4.04
line_render/Right/10📈 view plot
⚠️ NO THRESHOLD		564.71
line_render/Right/3📈 view plot
⚠️ NO THRESHOLD		284.18
line_render/Right/4📈 view plot
⚠️ NO THRESHOLD		342.85
line_render/Right/42📈 view plot
⚠️ NO THRESHOLD		833.43
line_render/Right/6📈 view plot
⚠️ NO THRESHOLD		459.75
line_render/Right/7📈 view plot
⚠️ NO THRESHOLD		510.49
list/render/16384📈 view plot
⚠️ NO THRESHOLD		1,227,400.00
list/render/2048📈 view plot
⚠️ NO THRESHOLD		322,250.00
list/render/64📈 view plot
⚠️ NO THRESHOLD		205,990.00
list/render_scroll_half/16384📈 view plot
⚠️ NO THRESHOLD		1,219,900.00
list/render_scroll_half/2048📈 view plot
⚠️ NO THRESHOLD		321,000.00
list/render_scroll_half/64📈 view plot
⚠️ NO THRESHOLD		139,060.00
paragraph/new/2048📈 view plot
⚠️ NO THRESHOLD		255,980.00
paragraph/new/64📈 view plot
⚠️ NO THRESHOLD		6,784.30
paragraph/new/65535📈 view plot
⚠️ NO THRESHOLD		8,078,400.00
paragraph/render/2048📈 view plot
⚠️ NO THRESHOLD		608,820.00
paragraph/render/64📈 view plot
⚠️ NO THRESHOLD		568,640.00
paragraph/render/65535📈 view plot
⚠️ NO THRESHOLD		1,639,200.00
paragraph/render_scroll_full/2048📈 view plot
⚠️ NO THRESHOLD		578,650.00
paragraph/render_scroll_full/64📈 view plot
⚠️ NO THRESHOLD		608,860.00
paragraph/render_scroll_full/65535📈 view plot
⚠️ NO THRESHOLD		1,631,700.00
paragraph/render_scroll_half/2048📈 view plot
⚠️ NO THRESHOLD		573,700.00
paragraph/render_scroll_half/64📈 view plot
⚠️ NO THRESHOLD		609,290.00
paragraph/render_scroll_half/65535📈 view plot
⚠️ NO THRESHOLD		1,613,800.00
paragraph/render_wrap/2048📈 view plot
⚠️ NO THRESHOLD		284,300.00
paragraph/render_wrap/64📈 view plot
⚠️ NO THRESHOLD		242,680.00
paragraph/render_wrap/65535📈 view plot
⚠️ NO THRESHOLD		1,481,900.00
paragraph/render_wrap_scroll_full/2048📈 view plot
⚠️ NO THRESHOLD		282,750.00
paragraph/render_wrap_scroll_full/64📈 view plot
⚠️ NO THRESHOLD		244,370.00
paragraph/render_wrap_scroll_full/65535📈 view plot
⚠️ NO THRESHOLD		1,482,200.00
rect_rows/rows/1024📈 view plot
⚠️ NO THRESHOLD		327.98
rect_rows/rows/16📈 view plot
⚠️ NO THRESHOLD		5.26
rect_rows/rows/65535📈 view plot
⚠️ NO THRESHOLD		20,391.00
sparkline/render/2048📈 view plot
⚠️ NO THRESHOLD		117,410.00
sparkline/render/256📈 view plot
⚠️ NO THRESHOLD		119,260.00
sparkline/render/64📈 view plot
⚠️ NO THRESHOLD		37,431.00
table/render/16384x2📈 view plot
⚠️ NO THRESHOLD		2,873,700.00
table/render/16384x4📈 view plot
⚠️ NO THRESHOLD		5,579,300.00
table/render/16384x8📈 view plot
⚠️ NO THRESHOLD		18,999,000.00
table/render/2048x2📈 view plot
⚠️ NO THRESHOLD		621,360.00
table/render/2048x4📈 view plot
⚠️ NO THRESHOLD		1,086,300.00
table/render/2048x8📈 view plot
⚠️ NO THRESHOLD		1,800,200.00
table/render/64x2📈 view plot
⚠️ NO THRESHOLD		330,370.00
table/render/64x4📈 view plot
⚠️ NO THRESHOLD		506,850.00
table/render/64x8📈 view plot
⚠️ NO THRESHOLD		604,470.00
table/render_scroll_half/16384x2📈 view plot
⚠️ NO THRESHOLD		2,915,400.00
table/render_scroll_half/16384x4📈 view plot
⚠️ NO THRESHOLD		5,564,600.00
table/render_scroll_half/16384x8📈 view plot
⚠️ NO THRESHOLD		19,181,000.00
table/render_scroll_half/2048x2📈 view plot
⚠️ NO THRESHOLD		639,050.00
table/render_scroll_half/2048x4📈 view plot
⚠️ NO THRESHOLD		1,086,100.00
table/render_scroll_half/2048x8📈 view plot
⚠️ NO THRESHOLD		1,793,000.00
table/render_scroll_half/64x2📈 view plot
⚠️ NO THRESHOLD		217,390.00
table/render_scroll_half/64x4📈 view plot
⚠️ NO THRESHOLD		334,950.00
table/render_scroll_half/64x8📈 view plot
⚠️ NO THRESHOLD		392,770.00
🐰 View full continuous benchmarking report in Bencher

@airblast-dev airblast-dev marked this pull request as draft October 7, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@airblast-dev