perf: remove various small allocations #1407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1407 /- ##
=====================================
Coverage 93.5% 93.5%
=====================================
Files 68 68
Lines 15970 15976 6
=====================================
Hits 14944 14950 6
Misses 1026 1026 ☔ View full report in Codecov by Sentry. |
Bencher Report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few minor allocation optimizations.
One thing to note is in 0a8d59d we can create a wrapper function with a generic and use that to remove an allocation in the case that a width is not provided by using
std::iter::repeat(val).take(col_count). Though in practice it worsened performance due to (I assume) branching.To state the obvious, the changes here don't actually affect any of the benchmarks results, but are just small free optimizations.