Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu, Debian, and FreeBSD fingerprints #245

Merged
merged 12 commits into from
Nov 13, 2019
Merged

Add Ubuntu, Debian, and FreeBSD fingerprints #245

merged 12 commits into from
Nov 13, 2019

Conversation

hdm
Copy link
Contributor

@hdm hdm commented Nov 7, 2019

Description

This changeset adds missing fingerprints for Ubuntu, Debian, and FreeBSD versions.

Motivation and Context

The existing fingerprint coverage was missing quite a few versions.

How Has This Been Tested?

recog_verify and rspec

Types of changes

New OS fingerprints for Ubuntu, Debian, and FreeBSD

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

자동등록방지를 위해 보안절차를 거치고 있습니다.

Please prove that you are human.

@hdm
Copy link
Contributor Author

hdm commented Nov 7, 2019

With regards to the FreeBSD fingerprints, some of them match multiple major versions, while others match multiple minor versions, the logic used for this PR is:

  1. If there is a major version multiple match, don"t assert an OS version at all for now, but still include a specific signature. Effectively this is a generic FreeBSD match, but if Recog ever supports multiple asserts and weighting, this information is still present for future development.

  2. If there is a minor version multiple match, assert only the oldest version, but document it in the fingerprint comment. Same as above, if we ever support multiple asserts, these can be split back out again.

@hdm
Copy link
Contributor Author

hdm commented Nov 7, 2019

The source of these changes is a mix of internal banner collection and this repository: https://github.com/richlamdev/ssh-default-banners/

@hdm
Copy link
Contributor Author

hdm commented Nov 7, 2019

looks like jruby CI is still failing, any suggestions?

@gschneider-r7
Copy link
Contributor

I fixed the jruby issue on master. You might need to rebase to get this PR to go green, though. Restarting the tests on travis-ci doesn"t seem to pull in my changes.

@hdm
Copy link
Contributor Author

hdm commented Nov 8, 2019

thanks! will rebase soon

@hdm
Copy link
Contributor Author

hdm commented Nov 8, 2019

thanks yall, this should be good to review/merge

@tsellers-r7
Copy link
Contributor

Thanks @hdm I"ll try to get this landed / released today.

@tsellers-r7 tsellers-r7 merged commit 429874b into rapid7:master Nov 13, 2019
@hdm hdm deleted the fingerprints/ssh branch April 2, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants