-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubuntu, Debian, and FreeBSD fingerprints #245
Conversation
With regards to the FreeBSD fingerprints, some of them match multiple major versions, while others match multiple minor versions, the logic used for this PR is:
|
All reactions
Sorry, something went wrong.
The source of these changes is a mix of internal banner collection and this repository: https://github.com/richlamdev/ssh-default-banners/ |
All reactions
Sorry, something went wrong.
looks like jruby CI is still failing, any suggestions? |
All reactions
Sorry, something went wrong.
I fixed the jruby issue on master. You might need to rebase to get this PR to go green, though. Restarting the tests on travis-ci doesn"t seem to pull in my changes. |
All reactions
Sorry, something went wrong.
thanks! will rebase soon |
All reactions
Sorry, something went wrong.
Use openjdk8 instead of system default (openjdk11). Allow jruby target to fail without affecting the overall build status.
…fingerprints/ssh
thanks yall, this should be good to review/merge |
All reactions
Sorry, something went wrong.
Thanks @hdm I"ll try to get this landed / released today. |
All reactions
-
👍 1 reaction
Sorry, something went wrong.
tsellers-r7
Successfully merging this pull request may close these issues.
None yet
Description
This changeset adds missing fingerprints for Ubuntu, Debian, and FreeBSD versions.
Motivation and Context
The existing fingerprint coverage was missing quite a few versions.
How Has This Been Tested?
recog_verify
andrspec
Types of changes
New OS fingerprints for Ubuntu, Debian, and FreeBSD
Checklist: