Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Fix rule yaml indent and provide rule creation feedback #421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rabbitstack
Copy link
Owner

What is the purpose of this PR / why it is needed?

Fix the wrong indentation in the rule labels and provide the feedback to user after creating the rule file.

What type of change does this PR introduce?


Uncomment one or more /kind <> lines:

/kind feature (non-breaking change which adds functionality)

/kind bug-fix (non-breaking change which fixes an issue)

/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)

/kind breaking (fix or feature that would cause existing functionality to not work as expected

/kind cleanup

/kind improvement

/kind design

/kind documentation

/kind other (change that doesn't pertain to any of the above categories)

Any specific area of the project related to this PR?


Uncomment one or more /area <> lines:

/area instrumentation

/area telemetry

/area rule-engine

/area filters

/area yara

/area event

/area captures

/area alertsenders

/area outputs

/area rules

/area filaments

/area config

/area cli

/area tests

/area ci

/area build

/area docs

/area deps

/area other

Special notes for the reviewer


Does this PR introduce a user-facing change?


@rabbitstack rabbitstack force-pushed the fix-rule-template-yaml-indent branch from c7f79da to 6a14825 Compare January 3, 2025 16:07
Fix the wrong indentation in the rule labels and provide
the feedback to user after creating the rule file.
@rabbitstack rabbitstack changed the title fix(cli): Fix rule yaml indent and provide feedback fix(cli): Fix rule yaml indent and provide rule creation feedback Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant