Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QQ: reduce memory use when dropping many messages at once. #12712

Merged
merged 1 commit into from
Nov 13, 2024
Merged

QQ: reduce memory use when dropping many messages at once. #12712

merged 1 commit into from
Nov 13, 2024

Conversation

kjnilsson
Copy link
Contributor

As may happen when a max_length configuration change is made when there are many messages on the queue.
Fixes #12608

@kjnilsson
QQ: reduce memory use when dropping many messages at once.
bfa293a 
As may happen when a max_length configuration change is made
when there are many messages on the queue.
@kjnilsson kjnilsson added this to the 4.0.4 milestone Nov 13, 2024
mkuratczyk
mkuratczyk approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@mkuratczyk mkuratczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a spike, but significantly smaller. Given this test case is pretty extreme (drops almost 5M messages), this should be fine for pretty much all normal situations.

Screenshot 2024-11-13 at 11 11 06

@michaelklishin michaelklishin modified the milestones: 4.0.4, 4.1.0 Nov 13, 2024
@michaelklishin michaelklishin merged commit 2795293 into main Nov 13, 2024
273 checks passed
@michaelklishin michaelklishin deleted the gh_12608 branch November 13, 2024 16:42
@mergify mergify bot mentioned this pull request Nov 13, 2024
Merged
michaelklishin added a commit that referenced this pull request Nov 13, 2024
@michaelklishin
Merge pull request #12716 from rabbitmq/mergify/bp/v4.0.x/pr-12712
eeaa668 
QQ: reduce memory use when dropping many messages at once. (backport #12712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@mkuratczyk mkuratczyk mkuratczyk approved these changes

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
backport-v4.0.x
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Quorum queues: memory spike when applying a max-length policy retroactively to a long queue
4 participants
@kjnilsson @michaelklishin @mkuratczyk @the-mikedavis