Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change from Memory to ReadOnlyMemory #928

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Conversation

bollhals
Copy link
Contributor

Proposed Changes

Aligns the type to the usage (None of them actually should modify the memory, as we're sending it, hence it should be read only.) Also the usage of
MemoryMarshal.TryGetArray<T>(ReadOnlyMemory<T>, ArraySegment<T>)
requires a ReadOnlyMemory not Memory.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin michaelklishin merged commit bef2029 into rabbitmq:master Aug 19, 2020
@michaelklishin
Copy link
Member

Thank you!

@michaelklishin
Copy link
Member

@bollhals this can be a candidate for backporting to 6.x. WDYT?

@bollhals
Copy link
Contributor Author

Yes this could be backported, but there's not much gain from it either. It's more consistency than anything else really.

@michaelklishin
Copy link
Member

OK

@bollhals bollhals deleted the ROM branch March 2, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants