change AmqpVersion to struct #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Aug 18, 2020
Comment on lines
101
to
104
| unchecked | ||
| { | ||
| return (Major * 397) ^ Minor; | ||
| } |
There was a problem hiding this comment.
Suggested change
| unchecked | |
| { | |
| return (Major * 397) ^ Minor; | |
| } | |
| return (Major, Minor).GetHashCode(); |
There was a problem hiding this comment.
That seems to require an extra dependency on System.Tuple_2, though.
There was a problem hiding this comment.
Thank you for the suggestion, it is definitely a nicer option but I'm not sure if it's worth an extra dependency (if it does require one, I'm unable to compile this on .NET Core 3.1 on MacOS as is).
There was a problem hiding this comment.
Due to .NET 4.6.1 this syntax isn't yet possible to use without additional dependencies. (Similar to that we can't use anonymous (int, int) return values)
michaelklishin
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Simple small change to change it to a struct. Avoids allocation.
Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
I've let resharper implement the equality members, which also changed the GetHashCode. But as the type is internal, this is not breaking.