Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce work allocations #910

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

bollhals
Copy link
Contributor

Proposed Changes

4506a70 does move the error handling from the work classes to the WorkService. This eliminates some async state machine allocations.

f1af6ac removes passing the IModel in the Work.Execute, as only the Shutdown required it, so it's now passed in the ctor of it.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Allocations before:
image

after:
image

Performance before:
image

after:
image

@michaelklishin
Copy link
Member

michaelklishin commented Jul 10, 2020

A roughly 27% reduction in execution time for this workload 👏

@michaelklishin michaelklishin merged commit cf6bcc2 into rabbitmq:master Jul 10, 2020
michaelklishin added a commit that referenced this pull request Jul 10, 2020
Reduce work allocations

(cherry picked from commit cf6bcc2)
michaelklishin added a commit that referenced this pull request Jul 12, 2020
@lukebakken lukebakken added this to the 7.0.0 milestone Jul 13, 2020
@bollhals bollhals deleted the reduceWorkAllocations branch March 2, 2021 20:52
@lukebakken lukebakken modified the milestones: 8.0.0, 7.0.0 Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants