make IncomingCommand a class and simplify code around it #1628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Similar to the frame one, there's also just one Command at a time. So it can be allocated once and updated throughout the lifetime.
This way it can be changed to a class instead of struct, and thus avoids all the complexity of the struct handling especially with the async code.
Slight performance increase as well.
Types of Changes
Checklist
CONTRIBUTING.md
documentFurther Comments
I've changed a few things along the way