Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Task.Factory.StartNew to specify TaskScheduler.Default #1358

Closed
wants to merge 1 commit into from

Conversation

brandonagr
Copy link

@brandonagr brandonagr commented Jun 15, 2023

Proposed Changes

Without specifying TaskScheduler.Default explicitly it will use TaskScheduler.Current, which could lead to unexpected behavior depending on what tasks call into this code

This fixes #1357

Types of Changes

What types of changes does your code introduce to this project?

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

Without specifying TaskScheduler.Default explicitly it will use TaskScheduler.Current, which could lead to unexpected behavior depending on what tasks call into this code
@pivotal-cla
Copy link

@brandonagr Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@michaelklishin
Copy link
Member

@pivotal-cla this is an obvious fix

@pivotal-cla
Copy link

@brandonagr This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@lukebakken
Copy link
Contributor

Thank you! I did this in #1388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants