Proposed Changes

Currently the socket write loop can silently fail with no ability to detect the failure. When it fails, assuming the whole socket isn't down, creates a weird situation where socket reads work fine but writes never occur.

While it would be ideal to be able to restart the write loop on such a failure, at least being able to log such a failure would be a good start.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• All tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in related repositories

Further Comments

I'd assume that the vast majority of the time, the problems that affect writing to the socket also affect reading from it. The reason I'm suggesting this change is because that doesn't always seem to be the case and really, there isn't any harm adding a logging call here.