Add TimeOut to Abort call in dispose #1164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1075
Fixes #938
cc @CeesKass
Note: this also modifies integration tests to add the test suite name to the connection name. This makes it much easier to know which tests may be having issues by looking at the RabbitMQ logs.
Proposed Changes
While testing my usage of the RabbitMQ.Client library against a blocked RabbitMQ server I encountered an infinitely hanging dispose of my publisher see #938
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyI'm not sure if this is a breaking change or not, I did not dive deep enough into the Abort procedure to know if anything can break when calling with a timeout
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.md
document