Use Stream.Read instead of .ReadByte for the first byte #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1140
branch
from
dc21bb3 to
5be4196
Compare
stebet
suggested changes
Feb 14, 2022
| { | ||
| throw new MalformedFrameException("Invalid AMQP protocol header from server"); | ||
| } | ||
| byte[] buf = new byte[1]; |
There was a problem hiding this comment.
Use a static reusable buffer, and instead try to read 7 bytes instead of multiple Read calls. It'll simplify the code a lot.
There was a problem hiding this comment.
If you didn't read 7 bytes you can immediately throw the MalformedFrameException. If you did read 7 bytes, continue with the processing as the old code does.
It appears that on occassion ReadByte can hang unexpectedly. Maybe Read does suffer this issue?
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1140
branch
from
69ba26b to
3f7bd11
Compare
|
The flaky tests exist on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that on occasion
Stream.ReadBytecan hang unexpectedly. MaybeStream.Readdoes not suffer this issue?Intended to address #1140