Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect RemotePort #1090

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Fix incorrect RemotePort #1090

merged 1 commit into from
Sep 21, 2021

Conversation

GitHubPang
Copy link
Contributor

Fix bug:
SocketFrameHandler.RemotePort was wrong.

Expected:
RemotePort = port of RemoteEndPoint.

Actual:
RemotePort = port of LocalEndPoint.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin michaelklishin merged commit f0b83d2 into rabbitmq:main Sep 21, 2021
@michaelklishin
Copy link
Member

Thank you!

michaelklishin added a commit that referenced this pull request Sep 21, 2021
Fix incorrect RemotePort

(cherry picked from commit f0b83d2)
michaelklishin added a commit that referenced this pull request Sep 21, 2021
Fix incorrect RemotePort

(cherry picked from commit f0b83d2)
@michaelklishin michaelklishin modified the milestones: 6.2.2, 6.2.3 Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants