Resolve #1039 Confirms Failure should use ShutdownInitiator.Library #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itiator.Library
|
I've run the tests locally on Windows with this change, and the |
michaelklishin
approved these changes
Apr 22, 2021
|
I cannot reproduce this failure locally either but such tests are very timing-sensitive. |
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Rather than using
ShutdownInitiator.ApplicationinModelBase.WaitForConfirmsOrDieAsync, useShutdownInitiator.Libraryso consumers of the library can react differently based on the source of the Close. See #1039.Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
Unfortunately, I cannot determine a mechanism by which I can add unit tests to verify this behavior. While this change can be considered a breaking change, it is binary compatible (no public interface changes), and the change aligns with the documented behavioral expectation of Models that were Closed by the library itself. I do not believe that any user of the library would have relied on the previous behavior.