Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding FxCop #917

Closed
lukebakken opened this issue Jul 13, 2020 · 1 comment · Fixed by #932
Closed

Consider adding FxCop #917

lukebakken opened this issue Jul 13, 2020 · 1 comment · Fixed by #932
Assignees
@lukebakken
Milestone
7.0.0

Comments

@lukebakken
Copy link
Contributor

As suggested by @danielmarbach in this comment:

Context capturing is applied to the continuation which is the end of the method. Though in general libs that don't need context capture should always opt out for every await. It would be best to even enable i.ex. Fxcop even if only https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2007?view=vs-2019 is activated
@lukebakken lukebakken added this to the 7.0.0 milestone Jul 13, 2020
@lukebakken lukebakken self-assigned this Jul 13, 2020
@danielmarbach danielmarbach mentioned this issue Aug 22, 2020
Merged
11 tasks
@danielmarbach
Copy link
Collaborator

PR added #932

For now, I only enabled the ConfigureAwait rule and disabled all the others. Once it is in we can start enabling more rules gradually

@lukebakken lukebakken modified the milestones: 8.0.0, 7.0.0 Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Add FxCop with only ConfigureAwait rule enabled for now danielmarbach/rabbitmq-dotnet-client
2 participants
@danielmarbach @lukebakken