Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DateTime for Headers in IBasicProperties #1691

Closed
msschl opened this issue Sep 27, 2024 · 2 comments
Closed

Allow DateTime for Headers in IBasicProperties #1691

msschl opened this issue Sep 27, 2024 · 2 comments
Labels
enhancement

Comments

@msschl
Copy link

msschl commented Sep 27, 2024

Is your feature request related to a problem? Please describe.

Allow passing in DateTime as object into the Headers property of the IBasicProperties object.

See

rabbitmq-dotnet-client/projects/RabbitMQ.Client/Impl/WireFormatting.Write.cs

Line 152 in be1d1e3

static int WriteFieldValueSlow(ref byte destination, ref byte fieldValue, object value)

Describe the solution you'd like

I think it needs to be implemented in

rabbitmq-dotnet-client/projects/RabbitMQ.Client/Impl/WireFormatting.Write.cs

Line 152 in be1d1e3

static int WriteFieldValueSlow(ref byte destination, ref byte fieldValue, object value)

Describe alternatives you've considered

No response

Additional context

No response
@lukebakken
Copy link
Contributor

lukebakken commented Oct 1, 2024 •
edited
Loading

The AMQP 0.9.1 protocol has no notion of date & time. You must serialize to/from some other format in your application itself.

@lukebakken lukebakken closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
@lukebakken
Copy link
Contributor

@msschl I just noticed that this client library has an AmqpTimestamp type, which can be serialized into the headers. It is basically a POSIX time. See the AmqpTimestamp.cs file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukebakken @msschl