You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I just created the issue. The code change is ready, every path of the tool leads to this function ssd_checker.is_ssd(). Unfortunately, for all of my usb flash drives, this function shows a "False" which is wrong, isn't it? Next time I find time, I'm going to try to find a tool to detect if it's a flash drive, if you don't have an idea to do it better.
The text was updated successfully, but these errors were encountered:
Maybe just before this line could be a great point to insert the ssd_checker.is_ssd()? Before this point, the only wipe method executed is the "wipe free space", which is allowed to executed regardless in HDDs and SSDs. After that, if we detect that the drive is SSD, we could break the loop. The next conditional checks are elif, so it should only be executed if ssd_checker.is_ssd() is false.
Like you said, there is another task that we need to tackle: inform the user. Some easy way to do it could be, just before we break the loop, we check:
if ssd_checker.is_ssd() is True and opt is not in ("1", "0") (wipe free space and exit interactive options)
or if ssd_checker.is_ssd() is True and any in path, root_path, home, home_all, swaps are not False
If any of the two above are True, we print a warning informing that the only method allowed on SSD drives is "wipe free space", and then break the loop.
Also we could include the warning in README.md to make it clear from the beginning.
Hi, I just created the issue. The code change is ready, every path of the tool leads to this function
ssd_checker.is_ssd()
. Unfortunately, for all of my usb flash drives, this function shows a "False" which is wrong, isn't it? Next time I find time, I'm going to try to find a tool to detect if it's a flash drive, if you don't have an idea to do it better.The text was updated successfully, but these errors were encountered: