Polish News for release 1.0.0 #165
Conversation
|
You'll notice that I added links for the ggplot2 issues linked in news. although not quite kosher with the style guide this is to avoid pkgdown creating spurious links to scales issues automatically. Easily removed if you prefer. |
|
Overall form LGTM - @batpigandme can you please take a proof reading pass too? |
NEWS.md
Outdated
| * Remove `plyr` and `dichromat` dependencies. `dichromat` is now suggested | ||
| (@dpseidel, #118). | ||
| * `ordinal_format()` gains new arguments: `prefix`, `suffix`, `big.mark`, `rules`, | ||
| and rules for French and Spanish are also provided (@larmarange, #149). |
There was a problem hiding this comment.
I'd switch a semi-colon in for the note at the end ⇨ "rules; rules for French and Spanish..."
NEWS.md
Outdated
|
|
||
| * `rescale_mid()` now properly handles NAs (@foo-bar-baz-qux, #104). | ||
| * `boxcox_trans()` is now invertible for `x >= 0` and requires positive values. | ||
| A new argument `offset` allows specification of both type 1 and type 2 Box-Cox |
There was a problem hiding this comment.
hyphens for "type-1" and "type-2" (since modifying …transformations)
|
|
||
| # scales 0.3.0 | ||
|
|
||
| * `rescale()` preserves missing values in input when the range of `x` is | ||
| (effectively) 0 (ggplot2#985). | ||
| (effectively) 0 ([ggplot2-985](https://www.github.com/tidyverse/ggplot2/issues/985)). | ||
|
|
||
| * Continuous colour palettes now use `colour_ramp()` instead of `colorRamp()`. | ||
| This only supports interpolation in Lab colour space, but is hundreds of |
There was a problem hiding this comment.
Is there a word missing here? "is hundreds of…" If no (which is totally possible), toss in a period?
There was a problem hiding this comment.
not sure why it's not showing up here but it does continue to say "hundreds of times faster." i've double checked the file.
There was a problem hiding this comment.
I believe you! The internet is weird.
Reorganized bullets according to tidyverse style guide for news before release. Also polished for consistency throughout. Updated news/index.html with pkgdown.