-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boxcox_trans functions not always valid #103
Comments
trans and inv are wrong - they should be:
With these changes, for all x >= 0, inv(trans(x)) == x. |
dpseidel
added a commit
to dpseidel/scales
that referenced
this issue
Jun 27, 2018
implements Modulus generalization, Closes r-lib#103
dpseidel
pushed a commit
that referenced
this issue
Jun 29, 2018
implements Modulus generalization, Closes #103
The Box-Cox and modulus transformations are distinct, yet this treats Box-Cox uses So a proper solution should provide Box-Cox and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In boxcox_trans, trans and inv functions include sign() and abs() (maybe for preserving order of values when 0<x<1 ?), but this then passes not totally correct functions to the transformer.
Using this form, for data 0 < x < 1, inv(trans(x)) != x
Eliminating those and using the basic formula for Box-Cox Power transformations:
I've confirmed this works for all of my data x>0, and that inv(trans(x)) == x. I've also used this to scale my axes successfully.
I'm new to git, so I'm just reporting this here.
The text was updated successfully, but these errors were encountered: