Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amptrics 0420 keyboard addition #24744

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Amptrics 0420 keyboard addition #24744

wants to merge 7 commits into from
149 −0

Conversation

vchowl
Copy link

@vchowl vchowl commented Dec 24, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Dec 24, 2024
View reviewed changes
keyboards/amptrics/0422/keyboard.json Outdated Show resolved Hide resolved
keyboards/amptrics/0422/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/amptrics/0422/readme.md Outdated Show resolved Hide resolved
keyboards/amptrics/0422/readme.md Outdated Show resolved Hide resolved
keyboards/amptrics/0422/keyboard.json Show resolved Hide resolved
vchowl
vchowl commented Dec 24, 2024
View reviewed changes
Copy link
Author

@vchowl vchowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review comments incorporated, re-review requested.

@vchowl vchowl requested a review from waffle87 December 24, 2024 08:25
@vchowl
Copy link
Author

vchowl commented Dec 24, 2024

@waffle87 let me know, if I am missing anything in this PR?

@waffle87
Copy link
Member

I have also marked an above comment as unresolved.

@vchowl vchowl requested a review from waffle87 December 25, 2024 03:50
@vchowl
Copy link
Author

vchowl commented Dec 26, 2024

Hope, I've resolved all the review comments, please spare some time on this merge. Appreciate your time, patience.

@vchowl vchowl requested a review from waffle87 December 27, 2024 10:33
@vchowl
Copy link
Author

vchowl commented Dec 28, 2024

Review comments incorporated, re-review requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 Awaiting requested review from waffle87

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchowl @waffle87