add handwired/dactyl_manuform/5x8 config #24726
Open
247
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waffle87
requested changes
Dec 17, 2024
keyboards/handwired/dactyl_manuform/5x8/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/handwired/dactyl_manuform/5x8/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/handwired/dactyl_manuform/5x8/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
|
Thank you for comments to my code. I will fix my files and i will run on my keyboard for checking codes. If code will be work i will upload codes and push request for your control. |
9 tasks
|
Hello. I need help. I've reviewed all the files and changes, added my comments, and tested them on my keyboard. The "Reopen deletion request" button is not active. Where can I read what needs to be done for the next step to merge? |
|
Reopening this PR as requested (in case you can't do that yourself due to some GitHub restrictions). |
change
"soft_serial_pin": "D0"
to
"serial": {
"pin": "D0"
}
|
I see that all reviews have been resolved. Could you tell me if there's anything else I should do? |
drashna
requested changes
Dec 27, 2024
keyboards/handwired/dactyl_manuform/5x8/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/handwired/dactyl_manuform/5x8/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the
handwired/dactyl_manuform/5x8keyboard to QMK Firmware. The5x8layout is a handwired version of the Dactyl Manuform with 5 rows and 8 columns per hand. It includes the following features:LAYOUT_5x8.Types of Changes
Issues Fixed or Closed by This PR
Checklist