Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "feature/encoder config both specified" warnings #24641

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Improve "feature/encoder config both specified" warnings #24641

merged 1 commit into from
Nov 30, 2024

Conversation

fauxpark
Copy link
Member

Description

When a feature flag or encoder config is specified in info.json and config.h, show the values extracted from both sources.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 26, 2024 04:50
zvecr
zvecr approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth just going to master, given its low risk and such a minor change.

@fauxpark fauxpark changed the base branch from develop to master November 28, 2024 14:37
@zvecr zvecr merged commit 1da8aa8 into qmk:master Nov 30, 2024
5 checks passed
@fauxpark fauxpark deleted the dupe-features-encoders-warning branch November 30, 2024 06:24
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@fauxpark @smallketchup82
Improve "feature/encoder config both specified" warnings (qmk#24641)
8b05239
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@fauxpark @jlaptavi
Improve "feature/encoder config both specified" warnings (qmk#24641)
70f8e48
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 5, 2024
@fauxpark @ilham-agustiawan
Improve "feature/encoder config both specified" warnings (qmk#24641)
f7873b8
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@fauxpark @DmNosachev
Improve "feature/encoder config both specified" warnings (qmk#24641)
2724014
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@fauxpark @SyrupSplashin
Improve "feature/encoder config both specified" warnings (qmk#24641)
f605068
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
cli qmk cli command enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @zvecr