-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SK75 #24601
SK75 #24601
Conversation
hello, my wireless code is implemented in the womier/common file, please help me check. If my code does not meet the QMK specification, please give me your opinion, I will deal with it immediately and modify it. |
Right now, all you can do is sit and wait. As per the "needs-core-wireless" label that was added, any wireless keyboard PRs are going to be on hold until there is core-wireless support. It is not feasible to maintain multiple keyboard-level wireless implementations. |
@waffle87 I've a question If my keyboard uses the Westberry trimode with the unified wireless source code located in /keyboards/westberry/wireless, would it count as core wireless since multiple keyboards from this vendor can use this code? here the code from westberry repo |
It’s not core, no. There are wireless APIs in the works and trimode keyboards won’t be merged until after they’re adapted to use it. You can do whatever you like with their code, but it won’t be merged into QMK upstream in its current form. |
Ok, continue to upload the code without wireless function |
That is not going to work out for you because according to the GPL license, all aspects of the source code for the firmware, including the wireless code, must be available. If you were to remove said code, you'd be in violation of that license. |
You misunderstand my meaning, now the wireless core can not be merged, I will remove the wireless function of my keyboard, only upload the wired version that meets the current requirements, and I will put the wireless version into my personal firmware, because my idea is that I want to do the keyboard can be merged, that's all. |
Still won't work. As per the PR checklist: Wireless-capable boards:
|
Added Three-mode keyboard Womier/SK75.
Description
Added Womier/SK75 mechanical keyboard
Submit wireless code and keyboard code
Types of Changes
Issues Fixed or Closed by This PR
Checklist