Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SK75 #24601

Closed
wants to merge 1 commit into from
Closed

SK75 #24601

wants to merge 1 commit into from

Conversation

LiuLiuQMK
Copy link

Added Three-mode keyboard Womier/SK75.

Description

Added Womier/SK75 mechanical keyboard
Submit wireless code and keyboard code

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [ x] Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x ] My code follows the code style of this project: C, Python
  • [ x] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the needs-core-wireless Waiting on a core-side Wireless/Bluetooth/LPM implementation. label Nov 14, 2024
@LiuLiuQMK
Copy link
Author

hello, my wireless code is implemented in the womier/common file, please help me check. If my code does not meet the QMK specification, please give me your opinion, I will deal with it immediately and modify it.

@waffle87
Copy link
Member

Right now, all you can do is sit and wait. As per the "needs-core-wireless" label that was added, any wireless keyboard PRs are going to be on hold until there is core-wireless support. It is not feasible to maintain multiple keyboard-level wireless implementations.

@kerlos
Copy link

kerlos commented Nov 17, 2024

Right now, all you can do is sit and wait. As per the "needs-core-wireless" label that was added, any wireless keyboard PRs are going to be on hold until there is core-wireless support. It is not feasible to maintain multiple keyboard-level wireless implementations.

@waffle87 I've a question

If my keyboard uses the Westberry trimode with the unified wireless source code located in /keyboards/westberry/wireless, would it count as core wireless since multiple keyboards from this vendor can use this code?

here the code from westberry repo
Westberry core wireless

@tzarc
Copy link
Member

tzarc commented Nov 17, 2024

It’s not core, no. There are wireless APIs in the works and trimode keyboards won’t be merged until after they’re adapted to use it. You can do whatever you like with their code, but it won’t be merged into QMK upstream in its current form.

@tzarc tzarc added the on hold label Nov 19, 2024
@LiuLiuQMK
Copy link
Author

Ok, continue to upload the code without wireless function

@adophoxia
Copy link
Contributor

Ok, continue to upload the code without wireless function

That is not going to work out for you because according to the GPL license, all aspects of the source code for the firmware, including the wireless code, must be available. If you were to remove said code, you'd be in violation of that license.

@LiuLiuQMK
Copy link
Author

You misunderstand my meaning, now the wireless core can not be merged, I will remove the wireless function of my keyboard, only upload the wired version that meets the current requirements, and I will put the wireless version into my personal firmware, because my idea is that I want to do the keyboard can be merged, that's all.

@tzarc
Copy link
Member

tzarc commented Nov 20, 2024

Still won't work.

As per the PR checklist:


Wireless-capable boards:

  • Given license abuse from vendors, QMK does not accept any vendor PRs for wireless- or Bluetooth-capable keyboards without wireless and/or Bluetooth code
    • Historically, vendors have done this in bad faith in order to attain downstream VIA compatibility with no intention of releasing wireless sources
    • QMK's license, the GPL2 , requires full source disclosure for any distributed binary -- including full sources for any keyboard shipped by vendors containing QMK and/or firmware-side VIA code
    • If a vendor's wireless-capable keyboard PR submission is lacking wireless capability, then the PR will be left on-hold and unmergeable until wireless bindings are provided
    • If a vendor's wireless-capable keyboard is merged into QMK before it's known that the board is wireless, then all existing and future PRs from the same vendor will be put on hold until wireless bindings for the offending keyboard are provided

@LiuLiuQMK LiuLiuQMK closed this Dec 6, 2024
@tzarc tzarc mentioned this pull request Dec 7, 2024
14 tasks
vlovini referenced this pull request in LiuLiuQMK/qmk_firmware Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap needs-core-wireless Waiting on a core-side Wireless/Bluetooth/LPM implementation. on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants