Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Handle_68 keyboard #24583

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add Handle_68 keyboard #24583

wants to merge 6 commits into from

Conversation

Alden5
Copy link

@Alden5 Alden5 commented Nov 10, 2024

Added Handle_68 keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fixed broken github link, added image of project
updated keyboard_name last minute, sorry so many commits im new to github :(
"vid": "0xFEED"
},
"layouts": {
"LAYOUT_68_mac": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"LAYOUT_68_mac": {
"LAYOUT": {

#include QMK_KEYBOARD_H

const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
[0] = LAYOUT_68_mac(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[0] = LAYOUT_68_mac(
[0] = LAYOUT(

Comment on lines 3 to 5
* a 68% keyboard with a handle!

# <img alt="photo of handle_68 keyboard" src="https://i.imgur.com/7ijNXEm.jpeg" style="width:50%; height:auto;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* a 68% keyboard with a handle!
# <img alt="photo of handle_68 keyboard" src="https://i.imgur.com/7ijNXEm.jpeg" style="width:50%; height:auto;">
a 68% keyboard with a handle!
![photo of handle_68 keyboard](https://i.imgur.com/7ijNXEm.jpeg)

Comment on lines 25 to 26
* **Bootmagic reset**: Hold down the esc key and plug in keyboard
* **Physical reset button**: Short the two pins on back of pcba labeled boot0 with tweezers and plug in keyboard
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks.

Suggested change
* **Bootmagic reset**: Hold down the esc key and plug in keyboard
* **Physical reset button**: Short the two pins on back of pcba labeled boot0 with tweezers and plug in keyboard
* **Bootmagic reset**: Hold down the ESC key and plug in keyboard
* **Physical reset button**: Short the two pins on back of PCB labeled boot0 with tweezers and plug in keyboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants