Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add Zodiark-V2 Split Keyboard #24488

Closed
wants to merge 13 commits into from
Closed

[Keyboard] Add Zodiark-V2 Split Keyboard #24488

wants to merge 13 commits into from

Conversation

Aleblazer
Copy link

Description

Add the Zodiark-V2 dedicated RP2040 keyboard, default and dual Cirque keymaps

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Aleblazer Aleblazer changed the title Zodiarkv2 [Keyboard] Add Zodiark-V2 Split Keyboard Oct 14, 2024
waffle87
waffle87 requested changes Oct 14, 2024
View reviewed changes
keyboards/aleblazer/zodiarkv2/keyboard.json
"extrakey": true,
"nkro": true,
"oled": true,
"rgblight": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"rgblight": false,

keyboards/aleblazer/zodiarkv2/config.h
Comment on lines 30 to 31
#define SPLIT_TRANSPORT_MIRROR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already in keyboard.json under split.transport.sync.matrix_state.

Suggested change
#define SPLIT_TRANSPORT_MIRROR

keyboards/aleblazer/zodiarkv2/keyboard.json
"watchdog": true
},
"bootmagic": {
"enabled": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"enabled": true,

keyboards/aleblazer/zodiarkv2/keyboard.json
Comment on lines 67 to 71
"rgblight": {
"led_count": 88,
"split": true,
"split_count": [44, 44]
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see little point having RGB-Light configuration when RGB Matrix should be used for this keyboard.

Suggested change
"rgblight": {
"led_count": 88,
"split": true,
"split_count": [44, 44]
},

keyboards/aleblazer/zodiarkv2/keyboard.json
},
"rgb_matrix": {
"driver": "ws2812",
"led_count": 88,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is calculated automatically.

Suggested change
"led_count": 88,

keyboards/aleblazer/zodiarkv2/keymaps/default/keymap.c
Comment on lines 16 to 17
#include "oled.c"
#include "encoder.c"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include "oled.c"
#include "encoder.c"

keyboards/aleblazer/zodiarkv2/keymaps/default/oled.c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, w.r.t including code. Also, if OLEDs are intended to be installed on this keyboard, this configuration should live at the keyboard level in a zodiarkv2.c file. That way it OLEDs will work for QMK Configurator users.

keyboards/aleblazer/zodiarkv2/keymaps/dualcirque/encoder.c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

keyboards/aleblazer/zodiarkv2/keymaps/dualcirque/keymap.c
Comment on lines 16 to 17
#include "oled.c"
#include "encoder.c"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include "oled.c"
#include "encoder.c"

keyboards/aleblazer/zodiarkv2/keymaps/dualcirque/oled.c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 29, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 requested changes

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aleblazer @waffle87