Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new pcb - chlx piche #24252

Merged
merged 9 commits into from
Dec 24, 2024
Merged

add new pcb - chlx piche #24252

merged 9 commits into from
Dec 24, 2024

Conversation

gaclee3b
Copy link
Contributor

@gaclee3b gaclee3b commented Aug 7, 2024

Description

Adding new Alice-style 60% pcb variant capable of being used in split / tented applications.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Aug 7, 2024
@gaclee3b gaclee3b changed the title add new pcb - chlx niche add new pcb - chlx piche Aug 7, 2024
gaclee3b added 2 commits August 7, 2024 02:19
@gaclee3b
Update readme.md
3a89a53 
checked in version was missing imgur link and had some stale fields that are now updated.
@gaclee3b
Update readme.md pcb name
04fe675 
missed stale pcb name at the very top
waffle87
waffle87 approved these changes Aug 7, 2024
View reviewed changes
keyboards/chlx/piche60/readme.md Outdated Show resolved Hide resolved
@waffle87 waffle87 requested a review from a team August 7, 2024 09:00
zvecr
zvecr requested changes Aug 7, 2024
View reviewed changes
keyboards/chlx/piche60/keymaps/via/config.h Outdated Show resolved Hide resolved
keyboards/chlx/piche60/keyboard.json Show resolved Hide resolved
gaclee3b and others added 2 commits August 7, 2024 16:09
@gaclee3b @zvecr @waffle87
Apply suggestions from code review
3409e23 
update bootmagic key assignment. update imagr link.

Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: jack <[email protected]>
remove config.h since default value 4 builds fine
424d477
@gaclee3b gaclee3b requested a review from zvecr August 7, 2024 20:12
@gaclee3b
Copy link
Contributor Author

can someone help get this approved and merged?

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 3, 2024
@gaclee3b
Copy link
Contributor Author

gaclee3b commented Oct 3, 2024

please don't stale this. I'm still unsure what change is being requested here. I am under the impression I fulfilled all PR requirements and have already gotten one approval.

@zvecr
Copy link
Member

zvecr commented Oct 3, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 4, 2024
fix hardware support to includ compatible case configs. fix hardware …
ce73a3c 
…availability to specify pcb is typically sold in-stock as bulk listing on r/mechmarket
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 18, 2024
@drashna drashna merged commit 276f84a into qmk:master Dec 24, 2024
3 checks passed
dpnetca pushed a commit to dpnetca/qmk_firmware that referenced this pull request Dec 24, 2024
@gaclee3b @zvecr @waffle87
add chlx piche (qmk#24252)
bc0c5f1 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: chalex <alejandrelee [email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaclee3b @zvecr @drashna @waffle87