Add ProtoKeeb keyboard request #23991
Conversation
…nto dev_branch Merging the Master branch with the dev_branch. All the Protokeeb QMK firmware development will be carried out in the dev_branch.
…dev_branch QMK dev_branch updated to the latest qmk firmware
…g to the QMK's new changelogs (renamed Protokeeb rev1 info.json to keyboard.json) and much more...
…hanges according to the PR Checklist documentation. Reorganized existing keymaps and added a new keymap.
…ed the keyboard specific configurations
Removed "rgb_test" RGB Light effect as requested by QMK Maintainer. Co-authored-by: Ryan <[email protected]>
Removed RGB Light's "driver" configuration as requested by QMK Maintainer. Co-authored-by: Ryan <[email protected]>
Changes according to QMK Maintainer's request. Co-authored-by: Ryan <[email protected]>
|
I wanted to bring up an issue with the Pull Request. It looks like the PR Lint Check failed after I made the changes to my keyboard.json file as suggested by @fauxpark. I ran the same test on my PC, and the lint check passed, and the firmware compiled successfully. I'm not sure why the QMK lint check failed on the pull request. |
|
You can see why in the section below. Click the Details link. |
Ok understood it was due to the via keymap present in the keyboard's directory. As mentioned by @drashna the via keymap is no longer acceptable in the keyboard firmware files. |
|
So do you understand what the next step is? |
Yes, I will remove the VIA keymap from the keyboard directory and create a separate pull request to submit the VIA keymap on the VIA QMK userspace repository. |
Removed Effect and Animation Settings with default values in order to avoid redefinitions of the same settings in the keyboard config file. Co-authored-by: jack <[email protected]>
Using the default PIO0 peripheral for the WS2812 LEDs instead of the PIO1 peripheral. Co-authored-by: jack <[email protected]>
Removed common bootloader instructions from the info.json file. Co-authored-by: Joel Challis <[email protected]>
Addition of matrix_scan_user() function as suggested by QMK Maintainer. Co-authored-by: Joel Challis <[email protected]>
Removed TRI_LAYER_ENABLE build option as it is no longer required. Co-authored-by: jack <[email protected]>
|
Hi @zvecr, @waffle87, and @fauxpark, I have implemented all the requested changes based on your feedback. Could you kindly re-review and update your reviews? This PR has been open for 7 months, and I’ve addressed all suggestions and modifications promptly. The PR still shows a "merging is blocked" message, and I want to ensure there’s nothing else pending from my side. Please let me know if any further changes are needed. Thank you for your time and assistance! |
|
Please stop pinging maintainers. We understand that your pull request is important to you, but it is one of several hundred the team has to deal with, and whilst quoting seven months (actually just over five) a large portion of that time has been waiting for you to perform the requested changes. The team will get to this in due course, asking for updates will not speed that up. |
Hi @tzarc, Thank you for your clarification. I understand that the maintainers are managing numerous pull requests, and I appreciate the effort that goes into maintaining the QMK repository. However, I would like to know if there is any intention to merge this pull request, as it has been open for several months. If my contribution does not align with the project's priorities or standards, please let me know. I would prefer to have clarity rather than continue making minor refinements without a clear path forward. This would help prevent wasting both my time and the resources of the QMK team. Thank you again for your feedback, and I look forward to hearing your thoughts. |
Description
The Protokeeb is a versatile 16-key (4 x 4) Numpad/Macropad/MIDI device designed by A-Tech Officials. It is perfect for anyone looking to get started with custom keyboards. This open-source hardware project is based on a Raspberry Pi Pico development board, making it easy to learn, build, and modify. Designed for developers and enthusiasts alike, the Protokeeb features per-key south-facing ARGB LEDs and much more.
For more information, visit the Protokeeb GitHub page.
Types of Changes
Checklist