Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draytronics Elise V1 - Refactor - Sleep wake key repeat fix, RBG sleep tweak, readme update #23922

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Draytronics Elise V1 - Refactor - Sleep wake key repeat fix, RBG sleep tweak, readme update #23922

wants to merge 6 commits into from
74 −4

Conversation

ghostseven
Copy link
Contributor

Description

A re-factoring of the V1 Elise board, that includes a fix for key repeat after waking from sleep. This is more prevalent when using a KVM or other non direct connection. This maybe related to the use of underglow but these adjustments fix the issue in testing. At the same time there is a small update to the README.md.

This is effectively the same changes as the V2 PR but this needs to be separate as it is for a different board

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Specific to the Elise V1 board this fixes key repeat after wake from sleep.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ghostseven
Update config.h
51f6b4b 
Lint fix for copyright header.
@ghostseven ghostseven requested a review from drashna June 15, 2024 09:48
@drashna drashna requested a review from a team July 11, 2024 05:09
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Sep 18, 2024
@ghostseven
Copy link
Contributor Author

Hi, is there anything I can do to get this over the line before it is removed?

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 14, 2024
fauxpark
fauxpark requested changes Oct 15, 2024
View reviewed changes
keyboards/draytronics/elise/readme.md Outdated Show resolved Hide resolved
@ghostseven ghostseven requested a review from fauxpark October 15, 2024 13:19
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 30, 2024
@ghostseven
Copy link
Contributor Author

Again this appears to be stuck, anything I can do to get this over the line.

waffle87
waffle87 reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these changes are being applied to all keymaps, I feel like they should simply live at the keyboard level in the keyboard.json file:

"usb": {
    "polling_interval": 8,
    "suspend_wakeup_delay": 3000
}

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Dec 5, 2024
@ghostseven
Copy link
Contributor Author

Since these changes are being applied to all keymaps, I feel like they should simply live at the keyboard level in the keyboard.json file:

"usb": {
    "polling_interval": 8,
    "suspend_wakeup_delay": 3000
}

This was at keyboard level, I was asked to move this to user level by @drashna on June 15th .......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 left review comments

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghostseven @drashna @fauxpark @waffle87