Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chew mono #23835

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Add Chew mono #23835

wants to merge 13 commits into from
183 −50

Conversation

flinguenheld
Copy link
Contributor

@flinguenheld flinguenheld commented May 31, 2024 •
edited
Loading

Description

Hello,
This is the unsplitted version of my chew keyboard.
A 34 keys with a RP2040 zero.

You can see the repo with all information here.

Chew mono

Thank you 🚀

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Keyboard (addition or update)
  • Enhancement/optimization
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Jun 3, 2024
View reviewed changes
keyboards/chew_mono/rules.mk Outdated Show resolved Hide resolved
keyboards/chew_mono/info.json Outdated Show resolved Hide resolved
@flinguenheld flinguenheld requested a review from zvecr June 3, 2024 07:34
@flinguenheld
Copy link
Contributor Author

flinguenheld commented Jun 6, 2024 •
edited
Loading

I've reorganised my folders like that:

keyboards
   |
   └──chew
       └──split
       └──mono

I had to rename the .json which is in the root folder in info.json otherwise it doesn't compile.

@flinguenheld flinguenheld requested a review from drashna July 1, 2024 18:19
drashna
drashna reviewed Jul 5, 2024
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be targeting develop, since it's a change/migrate,

Also, this really should have a mapping, so that qmk compile -kb chew will operate correctly for those that have already created configs.

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 19, 2024
@zvecr zvecr changed the base branch from master to develop August 19, 2024 02:19
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Aug 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 4, 2024
@drashna
Copy link
Member

drashna commented Oct 11, 2024

This has some merge conflicts that need resolving.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 12, 2024
@flinguenheld
Copy link
Contributor Author

They are due to the new sub folders that I've created.

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flinguenheld @drashna @zvecr