Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up RGB LED type #21859

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Clean up RGB LED type #21859

merged 2 commits into from
Sep 4, 2023

Conversation

fauxpark
Copy link
Member

Description

Renamed LED_TYPE -> rgb_led_t, and combined cRGB and cRGBW structs, as the only difference was the w component controlled by the RGBW define.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement core keyboard keymap documentation via Adds via keymap and/or updates keyboard for via support labels Aug 28, 2023
@fauxpark fauxpark requested a review from a team August 28, 2023 23:02
@zvecr zvecr merged commit 41bd4e3 into qmk:develop Sep 4, 2023
@fauxpark fauxpark deleted the rgb-led-type-cleanups branch September 4, 2023 00:29
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@fauxpark @mechlovin
Clean up RGB LED type (qmk#21859)
c7d27a4
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@fauxpark @zgagnon
Clean up RGB LED type (qmk#21859)
f32375f
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@fauxpark
Clean up RGB LED type (qmk#21859)
fad4fe5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr