Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include missing dependencies in setup.py #3611

Merged
merged 1 commit into from
May 25, 2022
Merged

Include missing dependencies in setup.py #3611

merged 1 commit into from
May 25, 2022

Conversation

will-cromar
Copy link
Collaborator

absl-py and cloud-tpu-client are both required for xla_dist.

Bonus: fix typo litbpu -> libtpu

@will-cromar will-cromar marked this pull request as ready for review May 25, 2022 18:46
@JackCaoG
Copy link
Collaborator

Do we need this to be backported to 1.12?

@will-cromar
Copy link
Collaborator Author

This issue would have been going on through several releases, but it should be safe to cherry-pick this into 1.12

Copy link
Contributor

@yeounoh yeounoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @will-cromar

@will-cromar will-cromar merged commit 893efc5 into master May 25, 2022
@will-cromar will-cromar deleted the wcromar-deps branch May 25, 2022 22:20
wonjoolee95 added a commit that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants