Feature: Implements MapFields() #289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Thanks for your contribution. A few things:
Thank you, this is a nice one ! |
|
I have this renamed to MapFields and will have users pass in a function. Still need to write a unit test. |
|
This pull request introduces 1 alert when merging 166e846 into ca464ef - view on LGTM.com new alerts:
Comment posted by LGTM.com |
hartym
reviewed
Jan 11, 2019
| def _wrapfunc(func, val): | ||
| try: | ||
| retval = func(val) # Attempt to use the function | ||
| except: |
There was a problem hiding this comment.
We should never use a "catchall" except, instead, catch Exception.
Not sure this behaviour is wanted though, as it may come to unpredictable behaviour.
hartym
reviewed
Jan 11, 2019
| nonlocal callFunc | ||
|
|
||
| b = {key: _wrapfunc(callFunc, value) for key, value in bag._asdict().items()} # iterate the wrapped callable | ||
| makenamedtuple = collections.namedtuple('Bag', ' '.join((b.keys()))) # constructor of the returned tuple |
There was a problem hiding this comment.
You can use @use_context and get/set the input/output type from there. I think it's better than guessing the user would want this namedtuple.
hartym
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at eventually implementing the feature request from:
Issue 285: Updating All Fields
There is more work that needs to be done, but I think if we can spec out what types of operations we would want future users to be able to do across all fields, this can become very useful, especially on the validation and possibly security front. Let me know your opinions on this, please.