-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stubgen : Adding a print message on ignoring module <path> #11476
base: master
Are you sure you want to change the base?
Conversation
What are these checks about? |
Looks like the tests are checking the stdout from stubgen, and failing because of the new print statement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and welcome to here!
I think the print
should be added to remove_blacklisted_modules
, as it stands the change is just going to print every module that goes through stubgen.
Oh ok. I will try that . |
I am not sure why the checks are failing again.. I tried doing
Am I doing something wrong? |
On running these changes on my local system, I got a few errors:
Also, modules in itself is a list, so making another list called module is not necessary I guess. Moreover, the list module that you just made will not have any attribute named path, rather its elements, i guess there needs to be a wrapper loop. I'll be trying to implement these changes as well. See if I can come around these issues. |
Btw I am supposed to return a list of modules which pass the if condition, right? Also in the error it says that |
The original version avoided calling |
Thank you . I will try to fix it further :) |
YES FINALLY THE CHECKS PASSED.. LESGOOO |
@Infinil following up from my comment on #11493 (comment) with one nit picky thing you can change, your PR title: We all know that it's "stubgen.py" (you're working on a Python codebase) but you've spelt that as "Stubgen py :", but the name for the command does not generally include ".py" so you can just call it "stubgen". You are also describing that your printing a message, but then also saying why you are printing that message. You can leave out that you're printing a message, but just say what you're printing/when you're printing, and it looks like you accidentally capitalized "Ignoring". As I mentioned, this is all nit picky and your PR title is fine, but since you said you are new and want to learn I'm trying to help 🙂 This is the example PR titles I would suggest:
Feel free to use any of these or come up with your own 🙂 (or just keep yours how it is if you really don't want to change it) |
Co-authored-by: Terence Honles <[email protected]>
Thank you for the help 🙂 .. btw should I close with comment or wait for a reviewer? |
@Infinil just wait. They're probably busy 😉 |
Sorry for the slow review response! The PR looks reasonable to me, but it has some conflicts. @noob8boi are you interested in fixing the conflicts? Somebody else can also help finish this PR. |
#9599
Description
I added a print command in <is_blacklisted_path> function which shows a message of ignoring module from BLACKLIST. I am really sorry if this PR is not helpful.
(Explain how this PR changes mypy.)
Test Plan
I am pretty new to open source contribution and I don't know if it's necessary to test a print command...