Allow partial overlap when checking overload alternatives #10390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@dlax Is this planned to be merged soon? |
|
Diff from mypy_primer, showing the effect of this PR on open source code: steam.py (https://github.com/Gobot1234/steam.py)
- steam/utils.py:539: error: Overloaded function implementation does not accept all possible arguments of signature 2 [misc]
steam/ext/commands/commands.py:802: error: Unused "type: ignore" comment [unused-ignore]
- steam/ext/commands/commands.py:851: error: Overloaded function implementation does not accept all possible arguments of signature 3 [misc]
- steam/ext/commands/cog.py:53: error: Overloaded function implementation does not accept all possible arguments of signature 1 [misc]
jinja (https://github.com/pallets/jinja)
src/jinja2/filters.py:1368: error: Overloaded function implementation does not accept all possible arguments of signature 2 [misc]
tornado (https://github.com/tornadoweb/tornado)
tornado/gen.py:177: error: Overloaded function implementation does not accept all possible arguments of signature 2 [misc]
spark (https://github.com/apache/spark)
python/pyspark/rdd.py:4304: error: Unused "type: ignore" comment [unused-ignore]
python/pyspark/sql/dataframe.py:1908: error: Unused "type: ignore" comment [unused-ignore]
python/pyspark/sql/dataframe.py:2041: error: Unused "type: ignore" comment [unused-ignore]
python/pyspark/sql/dataframe.py:6414: error: Unused "type: ignore" comment [unused-ignore]
python/pyspark/sql/connect/dataframe.py:298: error: Unused "type: ignore" comment [unused-ignore]
python/pyspark/sql/connect/dataframe.py:345: error: Unused "type: ignore" comment [unused-ignore]
hydra-zen (https://github.com/mit-ll-responsible-ai/hydra-zen)
- src/hydra_zen/typing/_builds_overloads.py:238: error: Overloaded function implementation does not accept all possible arguments of signature 3 [misc]
src/hydra_zen/typing/_builds_overloads.py:238: error: Overloaded function implementation does not accept all possible arguments of signature 2 [misc]
- src/hydra_zen/typing/_builds_overloads.py:238: error: Overloaded function implementation does not accept all possible arguments of signature 5 [misc]
- src/hydra_zen/typing/_builds_overloads.py:238: error: Overloaded function implementation does not accept all possible arguments of signature 7 [misc]
- src/hydra_zen/typing/_builds_overloads.py:472: error: Overloaded function implementation does not accept all possible arguments of signature 2 [misc]
src/hydra_zen/typing/_builds_overloads.py:472: error: Overloaded function implementation does not accept all possible arguments of signature 3 [misc]
- src/hydra_zen/typing/_builds_overloads.py:472: error: Overloaded function implementation does not accept all possible arguments of signature 4 [misc]
- src/hydra_zen/typing/_builds_overloads.py:472: error: Overloaded function implementation does not accept all possible arguments of signature 6 [misc]
- src/hydra_zen/typing/_builds_overloads.py:472: error: Overloaded function implementation does not accept all possible arguments of signature 8 [misc]
- src/hydra_zen/typing/_builds_overloads.py:657: error: Overloaded function implementation does not accept all possible arguments of signature 1 [misc]
- src/hydra_zen/typing/_builds_overloads.py:657: error: Overloaded function implementation does not accept all possible arguments of signature 5 [misc]
src/hydra_zen/typing/_builds_overloads.py:657: error: Overloaded function implementation does not accept all possible arguments of signature 4 [misc]
src/hydra_zen/typing/_builds_overloads.py:657: error: Overloaded function implementation does not accept all possible arguments of signature 7 [misc]
|
|
Rebased and resolved conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11004
The following case defines a function with both an explicit keyword argument and
**kwargsbut with types incompatible (intfor the explicit one,strfor**kwargs):Mypy raises an error "Overloaded function implementation does not accept all possible arguments of signature 1" but types are correctly inferred, so the error seems to be a false-positive.
Allowing partial overlap when checking compatibility between one overload alternative and the implementation fixes the issue (the error is no longer raised). Calling
is_callable_compatible(..., allow_partial_overlap=True)is documented to "returnTrueif there exists at least one call to left that's also a call to right"; which seems valid for overloads.(This appears so simple that it's quite possible that I missed something...)
Test Plan
Example above is included as a test case. No apparent breakage in the test suite.