[mypyc] Add a more detailed MRO explanation. #10293
Open
46
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vtable index is only needed for when we actually go through a vtable lookup. I don't believe this is actually a major performance improvement, but it should make it clearer what's improtant for each branch.
This is inspired by Rust's `--explain` mechanism. Instead of having huge multi-line error outputs by default, you need to pass in `explain` (here through setting `MYPYC_EXPLAIN=1` when running `mypyc`) in ordre to get a more detailed explanation for less obvious error messages from the mypyc compilation itself.
|
You could leverage the existing |
|
This is a reasonable idea. It's quite a big change to our error reporting philosophy, so we should discuss it in an issue first and brainstorm different approaches and other error conditions where this might be useful. It's probably not worth it just for this particular message, but if we can come up with a few more common error conditions where we could use this, it could be worthwhile. We should probably also have a shorter summary message corresponding to each detailed message. In this case, the short message that we'd show by default could be something like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This` include #10290)
This is inspired by Rust's
--explainmechanism. Instead of having huge multi-line error outputs by default, you need to pass inexplain(here through settingMYPYC_EXPLAIN=1when runningmypyc) in order to get a more detailed explanation for less obvious error messages from the mypyc compilation itself.This is more of a discussion piece at this stage, but I think that having detailed explanations for most of the
mypycerrors would help a lot with debugging errors quickly in general, especially since they're more restrictive than Python's normal rues.