Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-123961: remove global variable ModDict in _cursesmodule.c #123962

Merged
merged 2 commits into from
Sep 13, 2024
Merged

gh-123961: remove global variable ModDict in _cursesmodule.c #123962

merged 2 commits into from
Sep 13, 2024

Conversation

picnixz
Copy link
Contributor

@picnixz picnixz commented Sep 11, 2024 •
edited by bedevere-app bot
Loading

@picnixz picnixz removed the request for review from ericsnowcurrently September 11, 2024 16:00
@bedevere-app bedevere-app bot mentioned this pull request Sep 11, 2024
Closed
vstinner
vstinner approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a comment is put in a weird place, just move it.

Modules/_cursesmodule.c Outdated Show resolved Hide resolved
@picnixz
Avoid orphan comment for update_lines_cols.
462175c 
This moves the comment inside the `#if`-guarded block so that IDEs may choose not to render that comment on builds that do not support `update_lines_cols`.
@vstinner vstinner enabled auto-merge (squash) September 13, 2024 10:30
@vstinner vstinner merged commit 403f3dd into python:main Sep 13, 2024
35 checks passed
@picnixz picnixz deleted the curses/remove-global-dict-variable-123961 branch September 13, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picnixz @vstinner