gh-123849: Fix DumpTests.test_table_dump() crash on SQLite when foreign keys are enabled by default. #123859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… foreign keys are enabled by default. Thanks Derothin for the report. Test regression in de777e4.
felixxm
requested review from
berkerpeksag and
erlend-aasland
as code owners
|
@Derothin Thanks for the report 👍 Does it work for you? |
|
Yep, that works |
erlend-aasland
approved these changes
Oct 8, 2024
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 8, 2024
…re enabled by default (pythonGH-123859) (cherry picked from commit 14b44c5) Co-authored-by: Mariusz Felisiak <[email protected]>
|
GH-125163 is a backport of this pull request to the 3.13 branch. |
|
@erlend-aasland Many thanks for checking 🚀 |
efimov-mikhail
pushed a commit
to efimov-mikhail/cpython
that referenced
this pull request
Oct 9, 2024
…re enabled by default (python#123859)
erlend-aasland
pushed a commit
that referenced
this pull request
Oct 13, 2024
…are enabled by default (GH-123859) (#125163) (cherry picked from commit 14b44c5) Co-authored-by: Mariusz Felisiak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks Derothin for the report.
Test regression in de777e4.