Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-123823: Fix test_posix for unsupported posix_fallocate on NetBSD #123824

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Sep 7, 2024

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Sep 7, 2024
@furkanonder furkanonder added skip news and removed tests Tests in the Lib/test dir labels Sep 7, 2024
@furkanonder furkanonder added 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Sep 8, 2024
@sobolevn sobolevn added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes and removed 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Sep 8, 2024
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MandeepSinghPB08
Copy link

👍

@vstinner vstinner merged commit df4f0cb into python:main Sep 9, 2024
42 checks passed
@miss-islington-app
Copy link

Thanks @furkanonder for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2024
…tBSD (pythonGH-123824)

Fix test_posix for unsupported posix_fallocate on NetBSD.
(cherry picked from commit df4f0cb)

Co-authored-by: Furkan Onder <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 9, 2024

GH-123864 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 9, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2024
…tBSD (pythonGH-123824)

Fix test_posix for unsupported posix_fallocate on NetBSD.
(cherry picked from commit df4f0cb)

Co-authored-by: Furkan Onder <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 9, 2024

GH-123865 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 9, 2024
@vstinner
Copy link
Member

vstinner commented Sep 9, 2024

LGTM, merged, thanks @furkanonder.

vstinner pushed a commit that referenced this pull request Sep 9, 2024
…etBSD (GH-123824) (#123865)

gh-123823: Fix test_posix for unsupported posix_fallocate on NetBSD (GH-123824)

Fix test_posix for unsupported posix_fallocate on NetBSD.
(cherry picked from commit df4f0cb)

Co-authored-by: Furkan Onder <[email protected]>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x has failed when building commit df4f0cb.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/146/builds/9453) and take a look at the build logs.
  4. Check if the failure is related to this commit (df4f0cb) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/146/builds/9453

Failed tests:

  • test_wmi

Failed subtests:

  • test_wmi_query_repeated - test.test_wmi.WmiTests.test_wmi_query_repeated

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\test_wmi.py", line 40, in test_wmi_query_repeated
    self.test_wmi_query_os_version()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\test_wmi.py", line 28, in test_wmi_query_os_version
    r = wmi_exec_query("SELECT Version FROM Win32_OperatingSystem").split("\0")
        ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\test_wmi.py", line 23, in wmi_exec_query
    return _wmi.exec_query(query)
           ~~~~~~~~~~~~~~~^^^^^^^
TimeoutError: [WinError 258] The wait operation timed out

Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
…etBSD (GH-123824) (#123864)

gh-123823: Fix test_posix for unsupported posix_fallocate on NetBSD (GH-123824)

Fix test_posix for unsupported posix_fallocate on NetBSD.
(cherry picked from commit df4f0cb)

Co-authored-by: Furkan Onder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants