Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation of event_loop fixture #375

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

seifertm
Copy link
Contributor

  • Removed contradictory information on whether the loop from the event_loop fixture will be available as the global event loop
  • Replaced example of custom event loop with an example of redefining the scope of the event_loop fixture
  • Added recommendation to use a custom event loop policy rather than redefining the event_loop fixture

Closes #288

seifertm added 3 commits June 26, 2022 14:06
…not setting the global event loop.

Signed-off-by: Michael Seifert <[email protected]>
… than for setting a custom event loop.

Signed-off-by: Michael Seifert <[email protected]>
@seifertm seifertm requested review from asvetlov and Tinche as code owners June 26, 2022 12:26
@codecov-commenter
Copy link

Codecov Report

Merging #375 (08952ee) into master (f13c85f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #375    /-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files           3        3           
  Lines         275      275           
  Branches       41       41           
=======================================
  Hits          256      256           
  Misses         12       12           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13c85f...08952ee. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

possible contradictions in event_loop documentation
2 participants