Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'scope' to 'loop_scope' in error message #1004

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Rename 'scope' to 'loop_scope' in error message #1004

merged 1 commit into from
Dec 6, 2024

Conversation

tusharsadhwani
Copy link
Contributor

Ensures that when a wrong argument is passed, the non-deprecated loop_scope keyword arg is recommended.

seifertm
seifertm requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@seifertm seifertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out!
Would you be willing to adjust the tests accordingly and add an entry to the changelog? Or would you prefer one of the maintainers take care of it?

@tusharsadhwani
Copy link
Contributor Author

I can do that. Let me fix the tests too.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.83%. Comparing base (3f0fdfb) to head (c655b64).

Files with missing lines Patch % Lines
pytest_asyncio/plugin.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1004    /-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files           2        2           
  Lines         513      513           
  Branches       66       66           
=======================================
  Hits          466      466           
  Misses         28       28           
  Partials       19       19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharsadhwani
Copy link
Contributor Author

@seifertm how's this?

@seifertm seifertm added this to the v0.25 milestone Dec 6, 2024
@tusharsadhwani @seifertm
Rename 'scope' to 'loop_scope' in error message
c655b64 
fix failing test

Add changelog entry
@seifertm seifertm self-requested a review December 6, 2024 14:19
seifertm
seifertm approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@seifertm seifertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!
I squashed the commits and we can merge.

Thanks for the contribution!

@seifertm seifertm enabled auto-merge December 6, 2024 14:20
@seifertm seifertm added this pull request to the merge queue Dec 6, 2024
Merged via the queue into pytest-dev:main with commit dbf9991 Dec 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seifertm seifertm seifertm approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@Tinche Tinche Awaiting requested review from Tinche Tinche is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.25
Development

Successfully merging this pull request may close these issues.
3 participants
@tusharsadhwani @codecov-commenter @seifertm