Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate enum subclasses from toolkitapi.py [swmm-toolkit/shared_enum.py] #301

Open
jennwuu opened this issue Sep 27, 2021 · 1 comment
Open

Remove duplicate enum subclasses from toolkitapi.py [swmm-toolkit/shared_enum.py] #301

jennwuu opened this issue Sep 27, 2021 · 1 comment
Labels
type:discussion type:maintenance

Comments

@jennwuu
Copy link
Contributor

jennwuu commented Sep 27, 2021 •
edited
Loading

Remove duplicate enum subclasses from https://github.com/OpenWaterAnalytics/pyswmm/blob/master/pyswmm/toolkitapi.py, where the enums are already defined in https://github.com/OpenWaterAnalytics/swmm-python/blob/dev/swmm-toolkit/src/swmm/toolkit/shared_enum.py
@jennwuu jennwuu changed the title enum subclasses that duplicate swmm-toolkit/shared_enum.py Remove duplicate enum subclasses from toolkitapi.py [swmm-toolkit/shared_enum.py] Sep 27, 2021
@jennwuu
Copy link
Contributor Author

jennwuu commented Sep 27, 2021

Hey @michaeltryby, I started a new issue where we can discuss in detail for how we want to remove/replace the duplicate enum subclasses in pyswmm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:discussion type:maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jennwuu