Log messages to stdout instead of stderr #334
Conversation
pypiserver/__main__.py
Outdated
| @@ -20,7 20,7 @@ | |||
|
|
|||
|
|
|||
| def init_logging(level=None, frmt=None, filename=None): | |||
| logging.basicConfig(level=level, format=frmt) | |||
| logging.basicConfig(level=level, format=frmt, stream=sys.stdout) | |||
There was a problem hiding this comment.
Great, could you make it also optional and possible to specify from the configuration? Thanks!
| @@ -94,10 101,6 @@ def usage(): | |||
| -v | |||
| Enable verbose logging; repeat for more verbosity. | |||
|
|
|||
| --log-conf <FILE> | |||
| read logging configuration from FILE. | |||
| By default, configuration is read from `log.conf` if found in server's dir. | |||
There was a problem hiding this comment.
Great catch! We must've forgotten to remove this at some point in the past
pypiserver/__main__.py
Outdated
| @@ -117,6 120,9 @@ def usage(): | |||
| A format-string selecting Http-Error properties to log; set to '%s' to see them all. | |||
| [Default: %(body)s: %(exception)s \n%(traceback)s] | |||
|
|
|||
| --log-to-stdout | |||
| log messages to stdout instead of the default stderr | |||
There was a problem hiding this comment.
Since we're touching this, it might be better to give people some more configurability with this, for example:
--log-to-stream
Log messages to the specified stream. Valid values are "stdout", "stderr", or "none"
That way people can turn off string logging altogether if they want. With your refactor to the init_logging function, this should be pretty easy to add in. What do you think?
There was a problem hiding this comment.
Sounds good. I've added it to the PR. I've renamed it to log-stream to be more consistent with the log-file option
Co-authored-by: Matthew Planchard <[email protected]>
|
It took me a while to notice that the pipeline was failing, but it is fixed now. |
There was a problem hiding this comment.
This looks good to me! Thanks very much for the contribution, and feel free to join us on zulip
fixes #328