Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 740: initial attestation docs #16063

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Jun 6, 2024

This is still WIP; just putting it up for visibility and so I can cross-link with the PEP PRs.

See: python/peps#3768

CC @sethmlarson as an interested party 🙂

Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw requested a review from a team as a code owner June 6, 2024 18:15
@woodruffw woodruffw marked this pull request as draft June 6, 2024 18:15
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
docs/user/attestations/internals.md Outdated Show resolved Hide resolved
docs/user/attestations/internals.md Outdated Show resolved Hide resolved
docs/user/attestations/publish/v1.md Outdated Show resolved Hide resolved
docs/user/attestations/internals.md Outdated Show resolved Hide resolved
docs/user/attestations/publish/v1.md Outdated Show resolved Hide resolved
docs/user/attestations/publish/v1.md Outdated Show resolved Hide resolved
@woodruffw woodruffw mentioned this pull request Jun 18, 2024
21 tasks
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw marked this pull request as ready for review June 21, 2024 15:26
@woodruffw woodruffw changed the title WIP: initial attestation docs PEP 740: initial attestation docs Jun 21, 2024
@woodruffw
Copy link
Member Author

This should be good for a full review! It adds an initial set of documentation explaining PyPI's part of PEP 740, including a permalink (/attestations/publish/v1/) that publish attestations themselves will identify themselves with.

@woodruffw woodruffw self-assigned this Jun 21, 2024
@woodruffw woodruffw requested a review from di July 2, 2024 19:32
@woodruffw
Copy link
Member Author

woodruffw commented Jul 2, 2024

(NB: This doesn't include a security model page yet. I figured I'd do one as a follow-up, to keep the diff relatively small.)

docs/user/attestations/internals.md Outdated Show resolved Hide resolved
docs/user/attestations/internals.md Outdated Show resolved Hide resolved
docs/user/attestations/internals.md Outdated Show resolved Hide resolved
@woodruffw woodruffw requested a review from di July 13, 2024 00:45
Signed-off-by: William Woodruff <[email protected]>
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion.

docs/dev/development/attestation-internals.rst Outdated Show resolved Hide resolved
@DarkaMaul DarkaMaul mentioned this pull request Jul 18, 2024
5 tasks
@woodruffw woodruffw requested review from di and a team July 18, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants