-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Update installation method for linux users #972
Conversation
Update installation method for Ubuntu 23.04 or above and Ubuntu 22.04 of below
``` | ||
|
||
- Ubuntu 22.04 or below |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Ubuntu 22.04 or below | |
Or, install via pip: |
Installing via pip
is still recommended, since new versions of pipx
will be directly uploaded to PyPi and be pip-installable, in contrast to the version freeze in Ubuntu.
I'd tend to remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d even drop the and for other distributions part, most users should be smart enough to infer that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #982. Installing via pip may not work. Or maybe we can suggest users use pipx through zipapp?
curl -L https://github.com/pypa/pipx/releases/latest/download/pipx.pyz -o pipx.pyz
alias pipx="/path/to/python/interpreter pipx.pyz"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sueggesting the pyz is probably the best thing to do. Instead of alias
(which needs to be added to rc) it’s probably better to suggest adding a script fix somewhere in PATH that does exec ..../python ..../pipx.pyz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where should the zipapp be stored? And it must be updated by hand, this should probably be included in the script fix.
Also, I don't think it should be suggested to tweak the PATH (if that is what you want).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be added to ~/.local/bin
. pipx ensurepath
would add that to PATH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think of a script approach like in #849 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can merge this PR first, and leave all these works in the follow-up PRs? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, pipx.pyz
contains a shellbang header so it can be made executable directly.
Gentle ping @oviniciusfeitosa |
docs/changelog.md
Summary of changes
Test plan
Tested by running