Fix using run with file descriptors #1293
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. I just noticed that Have to do things differently then. Checking additionally for Upd. wasn't able to preserve fd for passing it as script path later. Reading content for these seems like a sane middle ground, and it works \o/ |
Bobronium
commented
Mar 17, 2024
Bobronium
commented
Mar 17, 2024
chrysle
reviewed
Mar 18, 2024
|
Please add an example for this functionality to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.d/(if the patch affects the end users)Fixes #1292
Summary of changes
Add
app_path.is_fifo()check and read it out.Test plan
Tested by running
python -m pipx run <(echo 'print("Hello world!")')