-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify single source #1580
Simplify single source #1580
Conversation
refering folks to their build system of choice.
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Thomas A Caswell <[email protected]>
Co-authored-by: Brénainn Woodsend <[email protected]>
Co-authored-by: Thomas A Caswell <[email protected]>
Co-authored-by: Thomas A Caswell <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Thomas A Caswell <[email protected]>
…x (in the right place?)
refering folks to their build system of choice.
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Thomas A Caswell <[email protected]>
Co-authored-by: Brénainn Woodsend <[email protected]>
Co-authored-by: Thomas A Caswell <[email protected]>
Co-authored-by: Thomas A Caswell <[email protected]>
@ChrisBarker-NOAA have you looked into the possibility of embedding a diagram? (#1276 (comment)) |
OK -- I think this is in good shape, and has addressed the concerns of everyone. Open Question: whether to include a diagram -- see: #1580 (comment) Other than that -- good to go. Editors -- anything else? |
Co-authored-by: Anderson Bravalheri <andersonbravalheri [email protected]>
Co-authored-by: Anderson Bravalheri <andersonbravalheri [email protected]>
Co-authored-by: Anderson Bravalheri <andersonbravalheri [email protected]>
Thanks for acknowledging that you saw my request. What's your opinion? I don't think I saw you sharing it anywhere — have I missed it? |
What would the diagram contain? I'm guessing some flow that depicts |
I don't think it's necessary -- it's just not that complicated. But I'm happy for the doc editor(s) to decide. -CHB |
@bwoodsend I made a diagram in this comment a while back: #1276 (comment). I imagined it'd be reused, maybe with some modifications. It's made with Mermaid. @ChrisBarker-NOAA okay, I hear you. In the interest of unblocking the effort, I withdraw that request for now. |
Thanks for slogging through all our comments, I think the end result is really nice and clear now! |
Glad it got through to the end this time! Thanks all -- it was a slog, but it's a much better document as a result of all the input. |
Here's to never seeing |
I'm no longer calling this a WIP -- I hope it's close to as good as it's going to get.
This is a follow-up to #1578 -- I made a mess of it when I tried to rebase.
The goal here is to have a simple, and not opinionated, page that guides folks to their build tool of choice's way to handle version strings.
Not sure if it's a guide or a discussion -- I put in discussion, but maybe it's more of a guide.
Now that I think about it -- if it's in discussions, then maybe it could be a lot longer, and go into why one might want to (or not want to) provide a version attribute in the importable package.
But I don't know that I want to moderate THAT discussion…
📚 Documentation preview 📚: https://python-packaging-user-guide--1580.org.readthedocs.build/en/1580/discussions/single-source-version/