Project URLs keys should be capitalized in pyproject.toml #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pretty much all other places, the project URLs mapping keys are capitalized, including the "setuptools" guide page. Update `pyproject.toml` too for consistency and current practices.
chrysle
approved these changes
May 18, 2023
There was a problem hiding this comment.
It makes sense to capitalize these keys. As the spec says, they are the labels for the urls and can be customized.
In this example, they are even quoted, but I don't think that's necessary.
bhrutledge
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure whether this is controversial or not.
In pretty much all other places, the project URLs mapping keys are capitalized, including the "setuptools" guide page. Update
pyproject.tomlexamples too for consistency and current practices.Examples:
packagingpackage: https://github.com/pypa/packaging/blob/main/pyproject.toml#L32-L34C6If the keys are not capitalized, the link labels look awkward on the PyPI page, e.g. https://pypi.org/project/ruff/